Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental build is broken #81

Closed
shadow-cs opened this issue Nov 1, 2018 · 0 comments · Fixed by #82
Closed

Incremental build is broken #81

shadow-cs opened this issue Nov 1, 2018 · 0 comments · Fixed by #82

Comments

@shadow-cs
Copy link
Contributor

This is caused by _GitInput having invalid items present:

  • HEAD is not separated by / (at least on Windows)
  • packed-refs is included even if it doesn't exist

Workaround

Introduce a target that runs after _GitInputs and fixes _GitInput.
@shadow-cs shadow-cs changed the title Incremental compilation is broken Incremental build is broken Nov 1, 2018
shadow-cs added a commit to shadow-cs/GitInfo that referenced this issue Nov 1, 2018
@shadow-cs
Fix incremental build
7c21e49 
By fixing _GitInput items to contain existing files only with correct
path separator.

Fixes devlooped#81
@shadow-cs shadow-cs mentioned this issue Nov 1, 2018
Merged
@kzu kzu closed this as completed in #82 Nov 2, 2018
kzu pushed a commit that referenced this issue Nov 2, 2018
@shadow-cs @kzu
Fix incremental build
c9f44f6 
By fixing _GitInput items to contain existing files only with correct
path separator.

Fixes #81
@devlooped devlooped locked and limited conversation to collaborators Sep 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incremental build shadow-cs/GitInfo
1 participant
@shadow-cs