Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsDirty is no more constant #287

Closed
fabianoriccardi opened this issue May 18, 2023 · 2 comments
Closed

IsDirty is no more constant #287

fabianoriccardi opened this issue May 18, 2023 · 2 comments
Labels
bug

Comments

@fabianoriccardi
Copy link

I had just upgraded GitInfo to v3.0.6. With respect to v2.x, the IsDirty flag is no more constant, and I cannot use it to generate the Assembly Metadata. Will you solve this regression?

Steps to Reproduce

[assembly: AssemblyInformationalVersion(ThisAssembly.Git.IsDirty ? "dirty" : "")]

Expected Behavior

It should compile, instead it says that IsDirty is not constant.

Version Info

GitInfo v3.0.6
@kzu
Copy link
Member

kzu commented Jun 5, 2023

use IsDirtyString instead as a workaround for now

kzu added a commit that referenced this issue Jun 5, 2023
@kzu
Ensure IsDirty is a constant
a5c1c50 
Fixes the regression reported in #287.
Fixes #285.
@kzu kzu mentioned this issue Jun 5, 2023
Merged
kzu added a commit that referenced this issue Jun 5, 2023
@kzu
Ensure IsDirty is a constant
7e335d9 
Fixes the regression reported in #287.
Fixes #285.
kzu added a commit that referenced this issue Jun 5, 2023
@kzu
Ensure IsDirty is a constant
6e2383f 
Fixes the regression reported in #287.
Fixes #285.
@kzu
Copy link
Member

kzu commented Jun 5, 2023

Fixed in #288. Shipping in v3.1.0

@kzu kzu closed this as completed Jun 5, 2023
@devlooped devlooped locked and limited conversation to collaborators Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kzu @fabianoriccardi