Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc: Add libglm #61

Merged
merged 6 commits into from
Jan 20, 2019
Merged

ppc: Add libglm #61

merged 6 commits into from
Jan 20, 2019

Conversation

ashquarky
Copy link
Contributor

Hi again!
Another powerpc library; this one is glm. This is adapted from the Switch version, everything seems to work fine! Hopefully I didn't stuff up cmake again - I needed to add -DCMAKE_SYSTEM_NAME since devkitppc.cmake doesn't set that and I was reluctant to use wii.cmake or whatever. Leave it alone and it'll force -rdynamic into the link flags...
In any case, this works well.
Thanks!

@ashquarky
Copy link
Contributor Author

Bumping the version down to 0.9.9.2 because of issues like this one.

@WinterMute
Copy link
Member

Bumping the version down to 0.9.9.2 because of issues like this one.

Are there more issues? We're using gcc 8.2.0 now which defaults to gnu++14

@ashquarky
Copy link
Contributor Author

My test app specifies gnu++11 in the makefile, so even on the latest toolchain it doesn't compile with 0.9.9.3. Using 0.9.9.2, however, it works great! Not aware of any other issues with it.

@fincs
Copy link
Member

fincs commented Nov 23, 2018

Why do you have gnu++11 in your makefile? Any reason why not just remove it?

@ashquarky
Copy link
Contributor Author

Sorry, I think I misworded my last post. It's not my app, just one I'm using for testing. I don't have write access to the repo, etc. etc.
Considering the Switch repos have 0.9.9.1 I thought shipping a slightly older package to work around an upstream bug would be okay.

@WinterMute
Copy link
Member

Depending on what the app is, you could submit a PR to it.

I think it's probably reasonable to set CMAKE_SYSTEM_NAME in devkitppc.cmake tbh. These cmake toolchain files are still very much a work in progress

@WinterMute
Copy link
Member

I made the CMAKE_SYSTEM_NAME change in the pkgbuild scripts package. cf631ce Can you try with out that line in your cmake configure now?

@ashquarky
Copy link
Contributor Author

Working great with dkp-libs/devkitpro-pkgbuild-helpers 1.2.2-1! bfe6caf removes CMAKE_SYSTEM_NAME.

@WinterMute WinterMute merged commit 3da74b4 into devkitPro:master Jan 20, 2019
@ashquarky ashquarky deleted the ppc-libglm branch January 20, 2019 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants