Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

added user-management-widget #458

Merged
merged 8 commits into from
Jan 31, 2024
Merged

added user-management-widget #458

merged 8 commits into from
Jan 31, 2024

Conversation

nirgur
Copy link
Collaborator

@nirgur nirgur commented Jan 28, 2024

No description provided.

@nirgur nirgur requested a review from tomerlichtash January 28, 2024 20:14
tomerlichtash
tomerlichtash previously approved these changes Jan 29, 2024
Copy link
Member

@tomerlichtash tomerlichtash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I wonder if loading the widget after login, by default with no tenant ID and no users to show, is a good experience, but perhaps we can change that later, or add instructions on how to add users after the authentication.

@nirgur
Copy link
Collaborator Author

nirgur commented Jan 29, 2024

Looks good!

I wonder if loading the widget after login, by default with no tenant ID and no users to show, is a good experience, but perhaps we can change that later, or add instructions on how to add users after the authentication.

If you managed to login you should have at least one user 😄
But I agree, maybe we should have another protected page for the widget
WDYT?

@tomerlichtash
Copy link
Member

But I agree, maybe we should have another protected page for the widget

I totally agree. It'll be easier to reference the example demo as well.

@nirgur
Copy link
Collaborator Author

nirgur commented Jan 29, 2024

But I agree, maybe we should have another protected page for the widget

I totally agree. It'll be easier to reference the example demo as well.

Done

@nirgur nirgur requested a review from tomerlichtash January 29, 2024 18:21
tomerlichtash
tomerlichtash previously approved these changes Jan 29, 2024
@nirgur nirgur merged commit 619d91b into main Jan 31, 2024
7 checks passed
@nirgur nirgur deleted the UMW branch January 31, 2024 12:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants