Skip to content
This repository has been archived by the owner on Jul 11, 2024. It is now read-only.

Override web component sdk configs #456

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

asafshen
Copy link
Member

Related Issues

https://github.com/descope/etc/issues/5319

Related PRs

descope/descope-js#356

Description

Override web component sdk configs so that the hooks running before will run in the same manner

@asafshen asafshen requested review from nirgur and Bars92 February 4, 2024 14:31
@asafshen asafshen marked this pull request as ready for review February 4, 2024 14:34
@asafshen asafshen enabled auto-merge (squash) February 4, 2024 14:37
Copy link
Collaborator

@nirgur nirgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Added a few small comments

@asafshen asafshen requested a review from nirgur February 4, 2024 22:49
@asafshen asafshen merged commit 51dec91 into main Feb 5, 2024
7 checks passed
@asafshen asafshen deleted the override-web-component-sdk-configs branch February 5, 2024 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants