chore(has-alt): use virtualNode instead of node #1923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straker
previously requested changes
Dec 3, 2019
lib/checks/shared/has-alt.js
Outdated
| return false; | ||
| } | ||
|
|
||
| return typeof virtualNode.attr('alt') === 'string'; |
There was a problem hiding this comment.
VirtualNode has a hasAttr function, any reason why you're not using it?
lib/checks/shared/has-alt.js
Outdated
| node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area') | ||
| ); | ||
| const { nodeName } = virtualNode.props; | ||
| if (['img', 'input', 'area'].includes(nodeName) === false) { |
There was a problem hiding this comment.
Why not !['img', 'input', 'area'].includes(nodeName)?
There was a problem hiding this comment.
Easier to spot the negation this way. Doesn't really matter I guess.
straker
approved these changes
Dec 4, 2019
straker
pushed a commit
that referenced
this pull request
Dec 11, 2019
* chore(has-alt): use virtualNode instead of node * chore(has-alt): ignore null alt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using DOM node in has-alt check.
Reviewer checks
Required fields, to be filled out by PR reviewer(s)