Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Feature/vote] implement getting candidates API #78

Merged
merged 23 commits into from
Mar 29, 2025
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7f4dfe3
Merge pull request #24 from depromeet/develop
yunyoung1819 Feb 11, 2025
96ca485
:sparkles: feat: create domain for voting
linirini Mar 22, 2025
e59015f
:white_check_mark: test: create RedisDatabaseCleaner And change Repos…
linirini Mar 23, 2025
9614e56
:wrench: config: fix ddl type error
linirini Mar 23, 2025
567cff1
:sparkles: feat: implement port for saving candidate
linirini Mar 23, 2025
72276ea
:sparkles: feat: implement port for saving votes
linirini Mar 23, 2025
b59d4cd
:sparkles: feat: implement port for loading candidates
linirini Mar 23, 2025
df0ba6a
:sparkles: feat: implement checking if candidates exists
linirini Mar 23, 2025
5c44a26
:sparkles: feat: implement getting recommended stations from cache
linirini Mar 23, 2025
19511ac
Merge branch 'develop', remote-tracking branch 'origin' into feature/…
linirini Mar 24, 2025
dc41579
:recycle: refactor: move getting recommended stations from adapter to…
linirini Mar 24, 2025
dee7f45
:sparkle: feat: implement get candidate usecase
linirini Mar 24, 2025
9da74b5
:sparkle: feat: implement get candidate Facade service and Controller
linirini Mar 24, 2025
d8b37e6
:sparkle: feat: add updating route names into "1호선"
linirini Mar 24, 2025
15af6ff
:sparkle: feat: implement deleting cache of recommended Stations
linirini Mar 25, 2025
b1444c6
:sparkle: feat: delete cached recommended stations after saving candi…
linirini Mar 25, 2025
bad648c
:recycle: refactor: refactor key-format for candidate
linirini Mar 25, 2025
e70c739
Merge branch 'develop' into feature/vote
linirini Mar 26, 2025
b659c98
Merge branch 'develop' into feature/vote
linirini Mar 26, 2025
d412b39
:recycle: refactor: merge conflict
linirini Mar 26, 2025
76c3deb
:recycle: refactor: remove route response
linirini Mar 28, 2025
dcf9e4f
Merge branch 'develop' into feature/vote
linirini Mar 29, 2025
2d40888
:recycle: refactor: use Station Facade Service for finding candidates
linirini Mar 29, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
♻️ refactor: remove route response
linirini committed Mar 28, 2025
commit 76c3deb21b861398c33b774e5ae6a53d8fbc3fda
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@
public record CandidateResponse(
long stationId,
String stationName,
List<RouteResponse> routes,
List<String> routes,
int totalTime,
int transferCount,
List<CommentResponse> comments
@@ -23,14 +23,14 @@ public static CandidateResponse of(
return new CandidateResponse(
station.getId(),
station.getName(),
getRouteResponses(routes),
getRoutes(routes),
transportationParsedResponse.totalTime(),
transportationParsedResponse.transferCount(),
comments
);
}

private static List<RouteResponse> getRouteResponses(List<Route> routes) {
return routes.stream().map(route -> new RouteResponse(route.getName())).toList();
private static List<String> getRoutes(List<Route> routes) {
return routes.stream().map(Route::getName).toList();
}
}

This file was deleted.