feat: enhance DoImageMultiPartUpload with URL encoding and improved l… #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| zap.String("contentType", req.Header.Get("Content-Type")), | ||
| zap.String("accept", req.Header.Get("Accept"))) | ||
| c.Sugar.Infow("Final request headers", | ||
| zap.Any("headers", req.Header), |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 4 months ago
To fix the problem, we should avoid logging sensitive information contained in the headers. Instead of logging all headers, we can selectively log non-sensitive headers or obfuscate sensitive values before logging.
The best way to fix this without changing existing functionality is to:
- Identify and exclude sensitive headers from being logged.
- Optionally, obfuscate the values of sensitive headers if they need to be logged for debugging purposes.
We will modify the logging statements to exclude or obfuscate sensitive headers.
Suggested changeset
1
httpclient/multipartrequest.go
| @@ -2,2 +2,3 @@ | ||
|
|
||
|
|
||
| import ( | ||
| @@ -484,5 +485,5 @@ | ||
| c.Sugar.Debugw("Initial headers", | ||
| zap.Any("headers", req.Header), | ||
| zap.String("accept", req.Header.Get("accept")), | ||
| zap.String("content-type", req.Header.Get("content-type"))) | ||
| zap.String("content-type", req.Header.Get("content-type")), | ||
| zap.String("authorization", obfuscateHeader(req.Header.Get("authorization")))) | ||
|
|
||
| @@ -500,5 +501,5 @@ | ||
| c.Sugar.Infow("Final request headers", | ||
| zap.Any("headers", req.Header), | ||
| zap.String("accept", req.Header.Get("accept")), | ||
| zap.String("content-type", req.Header.Get("content-type"))) | ||
| zap.String("content-type", req.Header.Get("content-type")), | ||
| zap.String("authorization", obfuscateHeader(req.Header.Get("authorization")))) | ||
|
|
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ogging
Change
Type of Change
Please DELETE options that are not relevant.
Checklist