feat: Add link to suppressed vulnerabilities header in HTML report #5620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to spot the link
This makes sure that the browser correctly scrolls to header when clicking the suppressed vulnerabilities link
jeremylong
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
none
Description of Change
Adds a link to the "Suppressed Vulnerabilities" section from the summary. This makes it easier for users to discover this section, and navigate to it, especially if there are multiple (vulnerable) dependencies listed in front of it.
Also automatically expands the section (is collapsed by default) for convenience.
Due to expanding being animated the browser might not scroll exactly to the correct location, but at least the section will be visible at the lower part of the screen.(fixed in latest commit)As side note: Maybe the UI for collapsible sections could be improved in general, for me it was not directly obvious previously that the "Suppressed Vulnerabilities" section can be expanded.
I am not sure if this is a clean enough solution and implementation, so feedback is appreciated!
Have test cases been added to cover the new functionality?
no