Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching Strategy - Product Names & Major Version Numbers #3207

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

jeremylong
Copy link
Collaborator

Fixes Issue #3193 and #3183

With 6.1.2 a new matching strategy was introduced that slowed down dependency-check. This PR removes the original implementation and improves the existing matching strategy to account for the fact that CPE product names may include the major version number.

…egy to account for the fact that CPE product names may contain the major version. This also resolves #3193 and #3183
@boring-cyborg boring-cyborg bot added the core changes to core label Mar 21, 2021
@jeremylong jeremylong added this to the 6.1.3 milestone Mar 21, 2021
@jeremylong jeremylong merged commit 96c34b0 into main Mar 21, 2021
@jeremylong jeremylong deleted the matchingStrategy branch March 22, 2021 11:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core changes to core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants