VACMS 20307 flippered Facility Locator Progressive Disclosure #34665

eselkin · 2025-02-13T04:11:42Z

DO NOT MERGE INTO MAIN - this is the base for the integration of changes for FL for staging review

Are you removing, renaming or moving a folder in this PR?

No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

No
Yes, and I used the proxy-rewrite steps to test the injected header scenario

Summary

Updates FL on small desktop sizes and up to match the new Figma designs
Updates to use va-button and other vads components
Sitewide team

Related issue(s)

Testing done

Updates tests to match new design on desktop

Screenshots

New Small Desktop Display

Before search

After search

Small Desktop Display Old

Tablet new (slight changes due to component changes)

Tablet old

Mobile has similar changes to tablet (but button extends on mobile)

Mobile map (new)

Mobile results (new)

Mobile Map (old)

Mobile Results (old)

What areas of the site does it impact?

Affects Facility Locator when flipper `` is on

Acceptance criteria

Check that with flipper on (RI flipper will be on soon) RI shows small desktop

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated (link to documentation *if necessary)
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check /find-locations
Check on all viewport sizes
Check for all facility types and representative number of services

…l changes

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/applications/facility-locator/components/search-form/service-type/ServicesLoadingOrShow.jsx

eselkin · 2025-02-21T18:43:03Z

So the geolocation check is probably facing this issue making it "flaky"-ish cypress-io/cypress#2671

Many people seem to have this issue. Unfortunately responses on that thread don't create an opportunity to have a delay in results from getCurrentPosition on the navigator in cypress/electron with the permission aware navigator methods. So we lose the functional test if we use their methods and lose the repeatability/consistency if we use ours.

error does not happen in cypress/chrome

src/applications/facility-locator/utils/mapHelpers.js

src/applications/facility-locator/utils/facilityDistance.js

randimays · 2025-02-21T18:29:49Z

src/applications/facility-locator/tests/reducers/searchQuery.unit.spec.js

@@ -204,7 +204,8 @@ describe('search query reducer', () => {
      type: FETCH_SPECIALTIES_FAILED,
    });

-    expect(state.error).to.eql(true);
+    expect(state.error).to.eql(true); // can be removed when dependent on the following only


Not quite clear on the comments here - do we anticipate removing error when we remove the progressive disclosure flipper?

Yes. Because error controls the alert in the results section. We have fetchSvcsError with progressive disclosure that is related to the service request/loading

src/applications/facility-locator/tests/e2e/providerSearch.cypress.spec.js

randimays · 2025-02-21T19:03:35Z

src/applications/facility-locator/tests/e2e/facilitySearchProgDisc.cypress.spec.js

@@ -0,0 +1,321 @@
+import mockFacilitiesSearchResultsV1 from '../../constants/mock-facility-data-v1.json';


@eselkin I saw you tagged me for re-review; were you anticipating still making changes to these Cypress files based on the helpers? I can still see quite a few places where we would use that. No worries if not! Just wanted to set my expectations correctly.

eselkin · 2025-02-25T23:17:01Z

@randimays should be good now. The geolocation test still sometimes randomly fails for no good reason. Now passes locally with electron and chrome so not sure what's making it fail on CI.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/applications/facility-locator/tests/e2e/geolocation.cypress.spec.js

Behind progressive disclosure flipper * Add orientation change on small desktop to FL * Add loading indicator when PPMS/CCP services are loading from external source * Add error message and reset state if error occurs in service request * Only show services selector/typeaheads/etc when requried by facility type * Changed text on PPMS typeahead error pursuant to figma * Added testing helpers for feature toggle interactions

eselkin added 10 commits February 4, 2025 09:41

change

7855f5a

work on prog

dbf655c

working flipper

5e856dc

fix

4beb339

checking error parity with prod

fc05586

checking error parity with prod

7f15113

Merge branch 'main' into VACMS-20307-restore-behavior-add-flag

82de822

fix resize observer

a1b0592

sizes

da45a82

fix tests

7d2d8e5

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 04:27 Error

true vs false in errors

ed7d5b5

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 05:10 Error

eselkin added 2 commits February 12, 2025 21:47

fix tests;

1bca3a1

clean up and fix tests - with flipper on off

43b7875

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 22:14 Error

Merge branch 'main' into VACMS-20307-restore-behavior-add-flag

0df1c1d

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 22:15 Error

clean up and fix tests - with flipper on off - last commit cleared al…

baf1c77

…l changes

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 23:43 Error

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 13, 2025 23:44 Error

fix test

936c018

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 14, 2025 00:49 Error

cleanup spacing a bit on errors

41ca1af

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 14, 2025 01:22 Error

Merge branch 'main' into VACMS-20307-restore-behavior-add-flag

eac6f0a

va-vfs-bot had a problem deploying to master/VACMS-20307-restore-behavior-add-flag/main February 14, 2025 01:25 Error

eselkin marked this pull request as ready for review February 14, 2025 01:35

eselkin requested review from a team as code owners February 14, 2025 01:35

cleanup

506cb2e

va-vfs-bot reviewed Feb 21, 2025

View reviewed changes

src/applications/facility-locator/components/search-form/service-type/ServicesLoadingOrShow.jsx Show resolved Hide resolved

src/applications/facility-locator/components/search-form/service-type/ServicesLoadingOrShow.jsx Show resolved Hide resolved

va-vfs-bot temporarily deployed to master/VACMS-20307-restore-behavior-add-flag/main February 21, 2025 06:51 Inactive

eselkin requested review from randimays and removed request for randimays February 21, 2025 16:23

randimays reviewed Feb 21, 2025

View reviewed changes

powellkerry previously approved these changes Feb 21, 2025

View reviewed changes

fixing tests

f8275c0

eselkin dismissed powellkerry’s stale review via f8275c0 February 21, 2025 21:04

va-vfs-bot temporarily deployed to master/VACMS-20307-restore-behavior-add-flag/main February 21, 2025 21:05 Inactive

fix test?

fece24c

va-vfs-bot temporarily deployed to master/VACMS-20307-restore-behavior-add-flag/main February 24, 2025 21:05 Inactive

documentation of featureTogglesToTest

313e0b3

va-vfs-bot temporarily deployed to master/VACMS-20307-restore-behavior-add-flag/main February 24, 2025 21:35 Inactive

eselkin requested a review from randimays February 24, 2025 21:43

fixed tests - used more helpers

3f324d1

va-vfs-bot temporarily deployed to master/VACMS-20307-restore-behavior-add-flag/main February 25, 2025 20:18 Inactive

delay geolocation result check

8251468

va-vfs-bot requested a review from a team February 26, 2025 02:24

va-vfs-bot reviewed Feb 26, 2025

View reviewed changes

src/applications/facility-locator/tests/e2e/geolocation.cypress.spec.js Show resolved Hide resolved

va-vfs-bot deployed to master/VACMS-20307-restore-behavior-add-flag/main February 26, 2025 02:25 View deployment

powellkerry approved these changes Feb 26, 2025

View reviewed changes

randimays approved these changes Feb 26, 2025

View reviewed changes

eselkin merged commit 4bdfc14 into main Feb 26, 2025
83 checks passed

eselkin deleted the VACMS-20307-restore-behavior-add-flag branch February 26, 2025 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VACMS 20307 flippered Facility Locator Progressive Disclosure #34665

VACMS 20307 flippered Facility Locator Progressive Disclosure #34665

eselkin commented Feb 13, 2025 •

edited by jilladams

Loading

va-vfs-bot left a comment

eselkin commented Feb 21, 2025 •

edited

Loading

randimays Feb 21, 2025

eselkin Feb 21, 2025

randimays Feb 21, 2025

eselkin commented Feb 25, 2025

va-vfs-bot left a comment

		@@ -0,0 +1,321 @@
		import mockFacilitiesSearchResultsV1 from '../../constants/mock-facility-data-v1.json';

VACMS 20307 flippered Facility Locator Progressive Disclosure #34665

VACMS 20307 flippered Facility Locator Progressive Disclosure #34665

Conversation

eselkin commented Feb 13, 2025 • edited by jilladams Loading

Are you removing, renaming or moving a folder in this PR?

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

eselkin commented Feb 21, 2025 • edited Loading

randimays Feb 21, 2025

Choose a reason for hiding this comment

eselkin Feb 21, 2025

Choose a reason for hiding this comment

randimays Feb 21, 2025

Choose a reason for hiding this comment

eselkin commented Feb 25, 2025

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

eselkin commented Feb 13, 2025 •

edited by jilladams

Loading

eselkin commented Feb 21, 2025 •

edited

Loading