Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simeplecov gem to fix parallel_test coverage bug #3279

Merged
merged 3 commits into from
Sep 10, 2019
Merged

Update simeplecov gem to fix parallel_test coverage bug #3279

merged 3 commits into from
Sep 10, 2019

Conversation

annaswims
Copy link
Contributor

@annaswims annaswims commented Sep 10, 2019 •
edited
Loading

Description of change

Fixes a bug in simplecov related to parallel_tests in simplecov simplecov-ruby/simplecov#706

Testing done

ran specs on jenkins

Acceptance Criteria (Definition of Done)

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to 366-upgrade_simplecov/master September 10, 2019 04:00 Inactive
@annaswims annaswims marked this pull request as ready for review September 10, 2019 04:03
@annaswims annaswims requested review from a team as code owners September 10, 2019 04:03
@va-vfs-bot va-vfs-bot temporarily deployed to 366-upgrade_simplecov/master September 10, 2019 14:51 Inactive
@annaswims annaswims merged commit dac4d1b into master Sep 10, 2019
@annaswims annaswims deleted the 366-upgrade_simplecov branch September 10, 2019 14:52
@annaswims annaswims added the VSP VSP Contract label Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jholton jholton jholton approved these changes

Assignees
No one assigned
Labels
VSP VSP Contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annaswims @jholton @va-vfs-bot