-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: streams utilities #1141
feat: streams utilities #1141
Conversation
One issue is that |
If you think about it almost everything in In fewer words, |
# Conflicts: # streams/conversion.ts
Not sure whats going wrong with CI in an unrelated module. testing locally works fine |
@crowlKats Could you rebase this? I'd love to land it. |
# Conflicts: # io/README.md # io/mod.ts # streams/conversion.ts # streams/conversion_test.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty happy with this. I'd love to get it landed before the release tomorrow.
@nayeemrmn or @kt3k do you have any strong objections?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections. Thinking further about it std/streams
makes more sense to have than std/io
, but I still think their scopes almost completely overlap and we should consider moving lots of other stuff over as well e.g. readLines()
, even the buffering utilities are revolved around streams.
Co-authored-by: Nayeem Rahman <nayeemrmn99@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it intentional to put Otherwise this looks good to me. |
I believe it's streams as in general io streams, not specifically whatwg streams. So |
Ok. Then it's fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
it kinda is more targeted towards whatwg streams, but since deprecating go-like streams isnt that far off, i think its fine to have those functions there for now, especially as some functions would make sense in both to some degree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @crowlKats!
TODO:
add examples forwill add examples in a separate PR once the new subprocess API landsmerge.ts