Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add ICU support in embedded v8. #382

Closed
wants to merge 2 commits into from
Closed

[WIP] Add ICU support in embedded v8. #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
673a762
Add submodule third_party/icu.
kishiguro May 26, 2020
e366b13
Set v8_enable_i18n_support = true in .gn for ICU support.
kishiguro May 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,6 @@
[submodule "third_party/zlib"]
path = third_party/zlib
url = https://chromium.googlesource.com/chromium/src/third_party/zlib.git
[submodule "third_party/icu"]
path = third_party/icu
url = https://chromium.googlesource.com/chromium/deps/icu
2 changes: 1 addition & 1 deletion .gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ default_args = {

# https://cs.chromium.org/chromium/src/docs/ccache_mac.md
clang_use_chrome_plugins = false
v8_enable_i18n_support = false
v8_enable_i18n_support = true
v8_monolithic = false
v8_use_external_startup_data = false
v8_use_snapshot = true
Expand Down
1 change: 1 addition & 0 deletions third_party/icu
Open in desktop
Submodule icu added at f22239