Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove 'explicit resource management' pass #290

Merged
merged 3 commits into from
Feb 14, 2025
Merged

feat: remove 'explicit resource management' pass #290

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d3f25ab
feat: Make 'explicit resource management' pass optional
bartlomieju Feb 14, 2025
b0a682b
fix
bartlomieju Feb 14, 2025
d89d704
remove completely
bartlomieju Feb 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 0 additions & 100 deletions src/transpiling/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,6 @@ pub fn fold_program(
proposal::decorator_2022_03::decorator_2022_03(),
options.use_decorators_proposal,
),
proposal::explicit_resource_management::explicit_resource_management(),
helpers::inject_helpers(marks.top_level),
// transform imports to var decls before doing the typescript pass
// so that swc doesn't do any optimizations on the import declarations
Expand Down Expand Up @@ -983,105 +982,6 @@ export class A {
assert!(transpiled_source.source_map.is_none());
}

#[test]
fn test_explicit_resource_management() {
let specifier =
ModuleSpecifier::parse("https://deno.land/x/mod.ts").unwrap();
let source = "using data = create();\nconsole.log(data);";
let program = parse_program(ParseParams {
specifier,
text: source.into(),
media_type: MediaType::TypeScript,
capture_tokens: false,
maybe_syntax: None,
scope_analysis: false,
})
.unwrap();
let transpiled_source = program
.transpile(
&TranspileOptions::default(),
&TranspileModuleOptions::default(),
&EmitOptions::default(),
)
.unwrap()
.into_source();
let expected_text = r#"function _using_ctx() {
var _disposeSuppressedError = typeof SuppressedError === "function" ? SuppressedError : function(error, suppressed) {
var err = new Error();
err.name = "SuppressedError";
err.suppressed = suppressed;
err.error = error;
return err;
}, empty = {}, stack = [];
function using(isAwait, value) {
if (value != null) {
if (Object(value) !== value) {
throw new TypeError("using declarations can only be used with objects, functions, null, or undefined.");
}
if (isAwait) {
var dispose = value[Symbol.asyncDispose || Symbol.for("Symbol.asyncDispose")];
}
if (dispose == null) {
dispose = value[Symbol.dispose || Symbol.for("Symbol.dispose")];
}
if (typeof dispose !== "function") {
throw new TypeError(`Property [Symbol.dispose] is not a function.`);
}
stack.push({
v: value,
d: dispose,
a: isAwait
});
} else if (isAwait) {
stack.push({
d: value,
a: isAwait
});
}
return value;
}
return {
e: empty,
u: using.bind(null, false),
a: using.bind(null, true),
d: function() {
var error = this.e;
function next() {
while(resource = stack.pop()){
try {
var resource, disposalResult = resource.d && resource.d.call(resource.v);
if (resource.a) {
return Promise.resolve(disposalResult).then(next, err);
}
} catch (e) {
return err(e);
}
}
if (error !== empty) throw error;
}
function err(e) {
error = error !== empty ? new _disposeSuppressedError(error, e) : e;
return next();
}
return next();
}
};
}
try {
var _usingCtx = _using_ctx();
var data = _usingCtx.u(create());
console.log(data);
} catch (_) {
_usingCtx.e = _;
} finally{
_usingCtx.d();
}"#;
assert_eq!(
&transpiled_source.text[..expected_text.len()],
expected_text
);
}

#[test]
fn test_transpile_tsx() {
let specifier =
Expand Down
Loading