Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dep_graph): make some types serializable #186

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Nov 15, 2023

This is so deno_graph doesn't need to recreate serializable types for these.

Waiting on #185

@@ -37,31 +41,38 @@ pub enum DependencyKind {
Require,
}

#[derive(Clone, Debug, Eq, PartialEq)]
pub enum ImportAssertion {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changes Assertion -> Attribute

@dsherret dsherret marked this pull request as ready for review November 15, 2023 17:21
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsherret dsherret merged commit 0172f00 into denoland:main Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants