Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop development for precompile JSX transform #179

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Oct 30, 2023

Currently, this transform doesn't really have a development behavior really. Exposing this in the transform options is therefore confusing.

What we did when development: true is that we imported from jsx-dev-runtime and called jsxDEV instead of jsx, but that has been more or less regarded as a design flaw of the jsx runtime proposal. These days everyone just aliases jsx-dev-runtime and jsx-runtime to the exact same file and aliases jsxDEV to jsx. The only difference between those functions is that jsxDEV receives more parameters about call location. Everyone just treats that as optional arguments to jsx these days.

For all those reasons it's best if we drop the development option of the precompile transform.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense 👍

@marvinhagemeister marvinhagemeister merged commit 74b9c28 into main Oct 30, 2023
@marvinhagemeister marvinhagemeister deleted the remove-jsx-dev branch October 30, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants