feat: optimize boolean attr handling #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML has a finite set of boolean attributes whose presence is interpreted as
true
, regardless of the actual attribute value and when it's not present it's interpreted asfalse
. Knowing that, we can bypass calling intojsxattr
to serialize and encode the value ourselves. If the value is a boolean literal we can serialize or skip the attribute ourselves too.It probably doesn't matter much for perf in the grand scheme of things, but I guess why not go all in.