feat: Upgrade V8 to 13.4 #28080
Merged
feat: Upgrade V8 to 13.4 #28080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devsnek
commented
Feb 12, 2025
•
devsnek
commented
- upgrade v8 to 13.4
- turbocall conversion for arraybuffers is now much more complex, so use cranelift
- misc updates for deprecated fns
- v8 default stack size is too small now, causing stack overflow exceptions in some tests
- add syscall shim to support new syscall in old sysroot
Closed
devsnek
force-pushed
the
x/upgrade-v8-134
branch
from
33b19d0 to
9817762
Compare
bartlomieju
reviewed
Feb 12, 2025
ext/ffi/turbocall.rs
Outdated
| @@ -1559,19 +1609,52 @@ mod tests { | |||
| // See https://godbolt.org/z/hqv63M3Ko | |||
There was a problem hiding this comment.
These links are probably out of date now?
devsnek
force-pushed
the
x/upgrade-v8-134
branch
6 times, most recently
from
7ef4c60 to
bd8945f
Compare
bartlomieju
approved these changes
Feb 14, 2025
| // https://github.com/microsoft/vscode/blob/48d4ba271686e8072fc6674137415bc80d936bc7/extensions/typescript-language-features/src/configuration/configuration.ts#L213-L214 | ||
| DenoSubcommand::Lsp => vec!["--max-old-space-size=3072".to_string()], | ||
| DenoSubcommand::Lsp => vec![ | ||
| "--stack-size=1024".to_string(), |
There was a problem hiding this comment.
Given that we need to always enable it, we should probably use it by default in deno_core. WDYT?
There was a problem hiding this comment.
its just a hack for now, i'm asking around about raising the default stack size in v8 to account for the recent change that caused this.
| @@ -2073,6 +2073,7 @@ fn napi_get_value_bool( | |||
| return napi_clear_last_error(env_ptr); | |||
| } | |||
|
|
|||
| #[allow(deprecated)] | |||
There was a problem hiding this comment.
We should get on updating these deprecated calls ASAP after landing this PR
devsnek
force-pushed
the
x/upgrade-v8-134
branch
from
50522b8 to
a28b980
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.