Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unstable): add js lint plugin source code helpers #28065

Merged
merged 4 commits into from
Feb 13, 2025
Merged

Conversation

marvinhagemeister
Copy link
Contributor

This PR adds a part of the SourceCode API in eslint (see https://eslint.org/docs/latest/extend/custom-rules#applying-fixes) . It's used to get the text of the current node, etc.

Comment on lines +1 to +2
const value = "unfixed";
console.log(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this file to contain more text including things like ligatures and emojis? Just to better stress text the utf16 codepoint handling.

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please see the comment

@bartlomieju bartlomieju merged commit e1871e5 into main Feb 13, 2025
18 checks passed
@bartlomieju bartlomieju deleted the lint-source branch February 13, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants