Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): deno task exit with status 0 #25637

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Sep 14, 2024

Fixes #25632

Exit code 1 indiciates some sort of failure but deno task (without arguments) is used to list available commands.

denoland#25632

Exit code 1 indiciates some sort of failure but `deno task` (without
arguments) is used to list available commands.
@littledivy littledivy requested a review from dsherret September 14, 2024 13:44
Copy link
Contributor

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks like one more test case needs to be updated

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit a666c8c into denoland:main Sep 15, 2024
17 checks passed
@littledivy littledivy deleted the deno_task_exit_code branch September 15, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider changing exit code of deno task (no args) from 1 to 0
3 participants