Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stabilize Deno.createHttpClient() #25569

Merged
merged 7 commits into from
Sep 12, 2024
Merged

feat: stabilize Deno.createHttpClient() #25569

merged 7 commits into from
Sep 12, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 11, 2024 •
edited
Loading

Closes #25518

@iuioiua iuioiua added the ci-draft Run the CI on draft PRs. label Sep 11, 2024
@iuioiua iuioiua changed the title feat(fetch): stabilize Deno.createHttpClient() feat(fetch): stabilize Deno.createHttpClient() and remove --unstable-http Sep 11, 2024
@iuioiua iuioiua removed the ci-draft Run the CI on draft PRs. label Sep 11, 2024
@iuioiua iuioiua marked this pull request as ready for review September 11, 2024 00:21
bartlomieju
bartlomieju reviewed Sep 11, 2024
View reviewed changes
@iuioiua iuioiua requested a review from bartlomieju September 11, 2024 22:50
@iuioiua iuioiua changed the title feat(fetch): stabilize Deno.createHttpClient() and remove --unstable-http feat(fetch): stabilize Deno.createHttpClient() Sep 11, 2024
bartlomieju
bartlomieju approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please remove (fetch) scope from the commit title before landing

@iuioiua iuioiua changed the title feat(fetch): stabilize Deno.createHttpClient() feat: stabilize Deno.createHttpClient() Sep 12, 2024
@iuioiua iuioiua merged commit 8476bbf into denoland:main Sep 12, 2024
17 checks passed
@iuioiua iuioiua deleted the stabilize-httpClient branch September 12, 2024 00:46
@magurotuna magurotuna mentioned this pull request Sep 17, 2024
Merged
magurotuna added a commit that referenced this pull request Sep 18, 2024
@magurotuna
fix(dts): stabilize fetch declaration for use with Deno.HttpClient (
f88a9e7 
#25683)

This commit stabilizes the `fetch` function declaration for use with
`Deno.HttpClient` and moves it from `lib.deno.unstable.d.ts` to
`lib.deno.shared_globals.d.ts`.

`Deno.HttpClient` was stabilized in #25569, but the associated override
declaration for `fetch` is still marked as experimental. This should
also be stabilized now and moved to a different d.ts file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stabilize Deno.createHttpClient()
2 participants
@iuioiua @bartlomieju