Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): validate export names #25436

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix(config): validate export names #25436

merged 1 commit into from
Sep 5, 2024

Conversation

marvinhagemeister
Copy link
Contributor

@marvinhagemeister marvinhagemeister commented Sep 4, 2024 •
edited
Loading

The property names of the exports field in deno.json was never validated. The patternProperties only validates values, whose property name matches the regex. It doesn't validate the property names themselves. That's what propertyNames is for.

Related #25435

@marvinhagemeister marvinhagemeister merged commit 4554ab6 into main Sep 5, 2024
17 checks passed
@marvinhagemeister marvinhagemeister deleted the config-schema branch September 5, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlomieju bartlomieju bartlomieju approved these changes

@dsherret dsherret Awaiting requested review from dsherret

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marvinhagemeister @bartlomieju