Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): use NotCapable error for permission errors #25431

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

lucacasonato
Copy link
Member

Closes #7394

@lucacasonato lucacasonato force-pushed the permission_denied_not_capable branch from 7c0b999 to d822c95 Compare September 4, 2024 14:27
@lucacasonato lucacasonato force-pushed the permission_denied_not_capable branch from 515d829 to 26d4d09 Compare September 5, 2024 07:36
@bartlomieju bartlomieju added this to the 2.0.0-rc.2 milestone Sep 8, 2024
@devsnek devsnek merged commit 7bfcb4d into main Sep 10, 2024
17 checks passed
@devsnek devsnek deleted the permission_denied_not_capable branch September 10, 2024 18:12
@iuioiua
Copy link
Contributor

iuioiua commented Sep 11, 2024

@lucacasonato
Copy link
Member Author

@iuioiua Yes, that was expected. It is only breaking the tests in error cases though, right? Not any success cases?

@iuioiua
Copy link
Contributor

iuioiua commented Sep 11, 2024

In std's case, it only affected failing cases. But we should also consider this can affect error-handling. So I think we should mark it as breaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a "NotCapable" error
4 participants