Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Node modules option for 2.0 #25299

Merged
merged 12 commits into from
Aug 29, 2024
Merged

feat(config): Node modules option for 2.0 #25299

merged 12 commits into from
Aug 29, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Aug 29, 2024 •
edited
Loading

No description provided.

@nathanwhit nathanwhit marked this pull request as draft August 29, 2024 18:52
@nathanwhit nathanwhit added the ci-draft Run the CI on draft PRs. label Aug 29, 2024
@nathanwhit nathanwhit marked this pull request as ready for review August 29, 2024 21:36
@nathanwhit nathanwhit removed the ci-draft Run the CI on draft PRs. label Aug 29, 2024
dsherret
dsherret approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nathanwhit nathanwhit merged commit 86d5b91 into denoland:main Aug 29, 2024
17 checks passed
@nathanwhit nathanwhit deleted the node-modules-option branch August 29, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret approved these changes

@bartlomieju bartlomieju Awaiting requested review from bartlomieju

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nathanwhit @dsherret