Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reland async context #25140

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: reland async context #25140

merged 1 commit into from
Aug 29, 2024

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Aug 21, 2024

This reverts commit 71ca61e.

Now uses a shared implementation from deno_core.

@devsnek devsnek changed the title Reapply "feat: async context" (#24856) feat: reland async context (#24856) Aug 21, 2024
@devsnek devsnek changed the title feat: reland async context (#24856) feat: reland async context Aug 21, 2024
devsnek added a commit that referenced this pull request Aug 29, 2024
- fix for #25160
- changes needed to land #25140
@devsnek devsnek enabled auto-merge (squash) August 29, 2024 01:22
@devsnek devsnek disabled auto-merge August 29, 2024 01:22
@devsnek devsnek enabled auto-merge (squash) August 29, 2024 01:22
@bartlomieju
Copy link
Member

@devsnek should this be a fix: given that it handles edge-cases that were previously ignored?

@devsnek devsnek disabled auto-merge August 29, 2024 01:30
@devsnek devsnek changed the title feat: reland async context fix: reland async context Aug 29, 2024
@devsnek devsnek enabled auto-merge (squash) August 29, 2024 01:30
@devsnek devsnek merged commit f7556d8 into main Aug 29, 2024
17 checks passed
@devsnek devsnek deleted the reland-async-ctx branch August 29, 2024 02:25
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
- fix for #25160
- changes needed to land #25140
lucacasonato pushed a commit that referenced this pull request Aug 29, 2024
This reverts commit 71ca61e.

Now uses a shared implementation from deno_core.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants