Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(node_compat): Add a write method to the FileHandle class #19385

Merged
merged 11 commits into from
Jun 8, 2023
Merged

feat(node_compat): Add a write method to the FileHandle class #19385

merged 11 commits into from
Jun 8, 2023

Conversation

k-nasa
Copy link
Contributor

@k-nasa k-nasa commented Jun 6, 2023 •
edited
Loading

WHY

ref: #19165

The FileHandle class has many missing methods compared to node.

WHAT

Add write method

@k-nasa
Copy link
Contributor Author

k-nasa commented Jun 6, 2023 •
edited
Loading

Looking at the latest Node documentation, it appears that the write method accepts an option as an argument, but I don't see such a definition in DefinitelyTyped/blob/d9df51e34526f48bef4e2546a006157b391ad96c/types/node/fs.d.ts. I will investigate further at a later date.

append: Understood that it is node 17.x

@k-nasa k-nasa mentioned this pull request Jun 6, 2023
Closed
@k-nasa
Copy link
Contributor Author

k-nasa commented Jun 7, 2023

CI seems to be falling in unrelated places..

@k-nasa
Copy link
Contributor Author

k-nasa commented Jun 8, 2023

@mmastrac I would be happy if you could review it. 🙏

@k-nasa k-nasa requested a review from mmastrac June 8, 2023 13:37
mmastrac
mmastrac approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmastrac mmastrac merged commit caad79e into denoland:main Jun 8, 2023
bartlomieju pushed a commit that referenced this pull request Jun 8, 2023
@k-nasa @bartlomieju
feat(node_compat): Add a write method to the FileHandle class (#19385)
94395a7 
## WHY 

ref: #19165

The FileHandle class has many missing methods compared to node.

## WHAT


Add write method
@k-nasa k-nasa deleted the k-nasa/feat_write branch June 14, 2023 12:33
@kt3k kt3k mentioned this pull request Sep 10, 2024
Open
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmastrac mmastrac mmastrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@k-nasa @mmastrac