Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING(cli/test): require equals for test jobs flag #15225

Closed

Conversation

mrkldshv
Copy link
Contributor

  • Adds required equals sign for jobs flag of the test command
  • Adds deprecation notice for jobs flag with numeric value

Resolves #14533. Ref #14929.

@mrkldshv
Copy link
Contributor Author

@dsherret Do you think we should deprecate --jobs flag in favour of new --parallel flag as per @nayeemrmn suggestion #14533 (comment)?

@dsherret
Copy link
Member

@mrkldshv yes I think so. I'd like to possibly get this in the release today so I have this done and will open a new PR adding you as a co-author. Still need to discuss it though.

@mrkldshv
Copy link
Contributor Author

Closing in favour of #15259.

@mrkldshv mrkldshv closed this Jul 20, 2022
@mrkldshv mrkldshv deleted the bugfix/require-equals-jobs-flag branch July 20, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno test --jobs flag should require equals when passing a value
2 participants