build: make rollup generate a depfile for the bundle build #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piscisaureus
force-pushed
the
rollupdeps
branch
10 times, most recently
from
4058fe2 to
15411cf
Compare
ry
reviewed
Oct 20, 2018
| const typescriptPath = path.resolve( | ||
| __dirname, | ||
| "third_party/node_modules/typescript/lib/typescript.js" | ||
| ); |
ry
approved these changes
Oct 20, 2018
| // Save the depfile just before the node process exits. | ||
| process.once("beforeExit", () => | ||
| writeDepFile({ outputFile, sourceFiles, configFiles, timestamp }) | ||
| ); |
There was a problem hiding this comment.
Is this the only hook to do this sort of thing? What if there's an error in rollup?
There was a problem hiding this comment.
🤷♂️ ... node will crash before the depfile gets written I suppose?
| load(sourceFile) { | ||
| // The 'globals' plugin adds generated files that don't exist on disk. | ||
| // Don't add them to the depfile. | ||
| if (/^[0-9a-f]{30}$/.test(sourceFile)) { |
| const outputDir = path.dirname(outputFile); | ||
|
|
||
| // Assert that the discovered bundle inputs are files that exist on disk. | ||
| sourceFiles.forEach(f => fs.accessSync(f)); |
There was a problem hiding this comment.
This throws if the file doesn't exist? I feel like assert(fs.existsSync(f)) would be more readable.
There was a problem hiding this comment.
Oh I was so entertained that I finally found a place where fs.access() had some modest utility.
| // Use forward slashes on Windows. | ||
| if (process.platform === "win32") { | ||
| filename = filename.replace(/\\/g, "/"); | ||
| } |
There was a problem hiding this comment.
This won't be necessary in deno, once #957 is done
piscisaureus
force-pushed
the
rollupdeps
branch
from
15411cf to
f471cb7
Compare
piscisaureus
force-pushed
the
rollupdeps
branch
from
f471cb7 to
3a6b2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.