Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno check and the LSP don't warn about ignored compilerOptions #25696

Closed
nathanwhit opened this issue Sep 18, 2024 · 0 comments · Fixed by #25714
Closed

deno check and the LSP don't warn about ignored compilerOptions #25696

nathanwhit opened this issue Sep 18, 2024 · 0 comments · Fixed by #25714
Labels
bug Something isn't working correctly
Milestone

Comments

@nathanwhit
Copy link
Member

deno run, deno test, and deno compile do warn, but deno check and the LSP do not.

Repro:

// deno.jsonc
{  
  "compilerOptions": {
    "noEmit": true,
  }
}
// main.ts (empty)
❯ deno run main.ts
Unsupported compiler options in "file:///repro/deno.json".
  The following options were ignored:
    noEmit
❯ deno check main.ts

Version: Deno x.x.x

@bartlomieju bartlomieju added the bug Something isn't working correctly label Sep 18, 2024
@bartlomieju bartlomieju added this to the 2.0.0 milestone Sep 18, 2024
bartlomieju pushed a commit that referenced this issue Sep 18, 2024
Update the config schema to error when adding unsupported
`compilerOptions`.

Fixes #25696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants