fix(BREAKING): make dns record types have consistent naming (#25357)

Closes #15207
denoland · Sep 2, 2024 · a3bd1ba · a3bd1ba
1 parent 42cf762
commit a3bd1ba
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 25 deletions.
diff --git a/cli/tsc/dts/lib.deno.ns.d.ts b/cli/tsc/dts/lib.deno.ns.d.ts
@@ -5773,7 +5773,7 @@ declare namespace Deno {
    *
    * @category Network
    */
-  export interface CAARecord {
+  export interface CaaRecord {
     /** If `true`, indicates that the corresponding property tag **must** be
      * understood if the semantics of the CAA record are to be correctly
      * interpreted by an issuer.
@@ -5793,7 +5793,7 @@ declare namespace Deno {
    * specified, it will return an array of objects with this interface.
    *
    * @category Network */
-  export interface MXRecord {
+  export interface MxRecord {
     /** A priority value, which is a relative value compared to the other
      * preferences of MX records for the domain. */
     preference: number;
@@ -5805,7 +5805,7 @@ declare namespace Deno {
    * specified, it will return an array of objects with this interface.
    *
    * @category Network */
-  export interface NAPTRRecord {
+  export interface NaptrRecord {
     order: number;
     preference: number;
     flags: string;
@@ -5818,7 +5818,7 @@ declare namespace Deno {
    * specified, it will return an array of objects with this interface.
    *
    * @category Network */
-  export interface SOARecord {
+  export interface SoaRecord {
     mname: string;
     rname: string;
     serial: number;
@@ -5833,7 +5833,7 @@ declare namespace Deno {
    *
    * @category Network
    */
-  export interface SRVRecord {
+  export interface SrvRecord {
     priority: number;
     weight: number;
     port: number;
@@ -5898,7 +5898,7 @@ declare namespace Deno {
     query: string,
     recordType: "CAA",
     options?: ResolveDnsOptions,
-  ): Promise<CAARecord[]>;
+  ): Promise<CaaRecord[]>;
 
   /**
    * Performs DNS resolution against the given query, returning resolved
@@ -5928,7 +5928,7 @@ declare namespace Deno {
     query: string,
     recordType: "MX",
     options?: ResolveDnsOptions,
-  ): Promise<MXRecord[]>;
+  ): Promise<MxRecord[]>;
 
   /**
    * Performs DNS resolution against the given query, returning resolved
@@ -5958,7 +5958,7 @@ declare namespace Deno {
     query: string,
     recordType: "NAPTR",
     options?: ResolveDnsOptions,
-  ): Promise<NAPTRRecord[]>;
+  ): Promise<NaptrRecord[]>;
 
   /**
    * Performs DNS resolution against the given query, returning resolved
@@ -5988,7 +5988,7 @@ declare namespace Deno {
     query: string,
     recordType: "SOA",
     options?: ResolveDnsOptions,
-  ): Promise<SOARecord[]>;
+  ): Promise<SoaRecord[]>;
 
   /**
    * Performs DNS resolution against the given query, returning resolved
@@ -6018,7 +6018,7 @@ declare namespace Deno {
     query: string,
     recordType: "SRV",
     options?: ResolveDnsOptions,
-  ): Promise<SRVRecord[]>;
+  ): Promise<SrvRecord[]>;
 
   /**
    * Performs DNS resolution against the given query, returning resolved
@@ -6080,11 +6080,11 @@ declare namespace Deno {
     options?: ResolveDnsOptions,
   ): Promise<
     | string[]
-    | CAARecord[]
-    | MXRecord[]
-    | NAPTRRecord[]
-    | SOARecord[]
-    | SRVRecord[]
+    | CaaRecord[]
+    | MxRecord[]
+    | NaptrRecord[]
+    | SoaRecord[]
+    | SrvRecord[]
     | string[][]
   >;
 

diff --git a/ext/node/polyfills/internal_binding/cares_wrap.ts b/ext/node/polyfills/internal_binding/cares_wrap.ts
@@ -270,7 +270,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
           );
         }),
         this.#query(name, "CAA").then(({ ret }) => {
-          (ret as Deno.CAARecord[]).forEach(({ critical, tag, value }) =>
+          (ret as Deno.CaaRecord[]).forEach(({ critical, tag, value }) =>
             records.push({
               type: "CAA",
               [tag]: value,
@@ -284,7 +284,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
           );
         }),
         this.#query(name, "MX").then(({ ret }) => {
-          (ret as Deno.MXRecord[]).forEach(({ preference, exchange }) =>
+          (ret as Deno.MxRecord[]).forEach(({ preference, exchange }) =>
             records.push({
               type: "MX",
               priority: preference,
@@ -293,7 +293,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
           );
         }),
         this.#query(name, "NAPTR").then(({ ret }) => {
-          (ret as Deno.NAPTRRecord[]).forEach(
+          (ret as Deno.NaptrRecord[]).forEach(
             ({ order, preference, flags, services, regexp, replacement }) =>
               records.push({
                 type: "NAPTR",
@@ -317,7 +317,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
           );
         }),
         this.#query(name, "SOA").then(({ ret }) => {
-          (ret as Deno.SOARecord[]).forEach(
+          (ret as Deno.SoaRecord[]).forEach(
             ({ mname, rname, serial, refresh, retry, expire, minimum }) =>
               records.push({
                 type: "SOA",
@@ -332,7 +332,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
           );
         }),
         this.#query(name, "SRV").then(({ ret }) => {
-          (ret as Deno.SRVRecord[]).forEach(
+          (ret as Deno.SrvRecord[]).forEach(
             ({ priority, weight, port, target }) =>
               records.push({
                 type: "SRV",
@@ -378,7 +378,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
 
   queryCaa(req: QueryReqWrap, name: string): number {
     this.#query(name, "CAA").then(({ code, ret }) => {
-      const records = (ret as Deno.CAARecord[]).map(
+      const records = (ret as Deno.CaaRecord[]).map(
         ({ critical, tag, value }) => ({
           [tag]: value,
           critical: +critical && 128,
@@ -401,7 +401,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
 
   queryMx(req: QueryReqWrap, name: string): number {
     this.#query(name, "MX").then(({ code, ret }) => {
-      const records = (ret as Deno.MXRecord[]).map(
+      const records = (ret as Deno.MxRecord[]).map(
         ({ preference, exchange }) => ({
           priority: preference,
           exchange: fqdnToHostname(exchange),
@@ -416,7 +416,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
 
   queryNaptr(req: QueryReqWrap, name: string): number {
     this.#query(name, "NAPTR").then(({ code, ret }) => {
-      const records = (ret as Deno.NAPTRRecord[]).map(
+      const records = (ret as Deno.NaptrRecord[]).map(
         ({ order, preference, flags, services, regexp, replacement }) => ({
           flags,
           service: services,
@@ -459,7 +459,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
 
       if (ret.length) {
         const { mname, rname, serial, refresh, retry, expire, minimum } =
-          ret[0] as Deno.SOARecord;
+          ret[0] as Deno.SoaRecord;
 
         record = {
           nsname: fqdnToHostname(mname),
@@ -480,7 +480,7 @@ export class ChannelWrap extends AsyncWrap implements ChannelWrapQuery {
 
   querySrv(req: QueryReqWrap, name: string): number {
     this.#query(name, "SRV").then(({ code, ret }) => {
-      const records = (ret as Deno.SRVRecord[]).map(
+      const records = (ret as Deno.SrvRecord[]).map(
         ({ priority, weight, port, target }) => ({
           priority,
           weight,