Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds rector and the suggested fixes for the config #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adds rector and the suggested fixes for the config #2

wants to merge 1 commit into from

Conversation

cjschneider2
Copy link
Collaborator

No description provided.

christianhaberland
christianhaberland requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@christianhaberland christianhaberland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evtl. bin ich ja auch blind. Es ist Montag Morgen ;)

Allerdings fehlt mir im PR das Einbindes des Packages in der composer.json.

@msouili msouili assigned msouili and unassigned msouili Feb 4, 2025
@msouili
Copy link

msouili commented Feb 4, 2025

The issue "access to uninitialized static property HttpClient::$instance" is already addressed in this PR #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianhaberland christianhaberland christianhaberland requested changes

@jpedryc jpedryc Awaiting requested review from jpedryc

@msouili msouili Awaiting requested review from msouili

@lfeldtmann lfeldtmann Awaiting requested review from lfeldtmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjschneider2 @msouili @christianhaberland