Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent hide on popup window losing focus, fixed escape key listener to close popup #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

violet-isle
Copy link

Popup windows used to close immediately of loss of focus, and for some window managers this was instant, as focus can be directed to the mouse pointer instead of the most recent window. This fixes that, as well as fixing the escape key listener, that didn't function, as the listener was added to a window that was not focused at the time.

I can see the use of a popup disappearing on loss of focus, and if this becomes an issue, a cancel or X button might be the better way to go, just for compatibility reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant