fix(rust): on write, have a schema evolution maintain metadata table id #3275
+177
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamphmurphy
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
liamphmurphy
changed the title
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
liamphmurphy
changed the title
rtyler
previously approved these changes
Feb 27, 2025
rtyler
changed the title
rtyler
changed the title
rtyler
force-pushed
the
fix/maintain_table_id_through_schema_evolution
branch
from
20292a8 to
e97466c
Compare
rtyler
changed the title
auto-merge was automatically disabled
February 27, 2025 19:59
Head branch was pushed to by a user without write access
liamphmurphy
force-pushed
the
fix/maintain_table_id_through_schema_evolution
branch
from
758b6cf to
0b3b218
Compare
liamphmurphy
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3275 +/- ##
==========================================
- Coverage 72.11% 72.09% -0.02%
==========================================
Files 143 143
Lines 45530 45537 +7
Branches 45530 45537 +7
==========================================
- Hits 32833 32830 -3
- Misses 10618 10624 +6
- Partials 2079 2083 +4 ☔ View full report in Codecov by Sentry. |
|
@liamphmurphy can you squash the commits and fix the CI? |
rtyler
force-pushed
the
fix/maintain_table_id_through_schema_evolution
branch
from
e715999 to
3db01ed
Compare
rtyler
previously approved these changes
Feb 28, 2025
…in new metadata transaction Signed-off-by: Liam Murphy <liam@phmurphy.com>
rtyler
force-pushed
the
fix/maintain_table_id_through_schema_evolution
branch
from
3db01ed to
1a3f32e
Compare
ion-elgreco
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a schema evolution write occurs, if a metadata ID from the table state exists, use that in the new metadata transaction entry.
This PR has a unit test and a new integration test that runs a Pyspark stream between evolution runs. I confirmed that the integration test failed with the error I've seen in production when I removed the new logic, and passes with the new logic.
Related Issue(s)
closes #3274
Documentation