refactor: replaced asterisk with constraint name in get_constraints

[Nordalf]

Description

When retrieving constraints from the table config, the name is set to an asterisk (*). The name is needed if you want to e.g. drop the constraint again. I have modified the code to use the found keys excluding delta.constraints..

Before:

"name": "*",
"expr": "double LIKE 'DO%' AND double LIKE '%IT%'"

After:

"name": "my_new_constraint_name",
"expr": "double LIKE 'DO%' AND double LIKE '%IT%'"

Going through the code, I discovered the reason behind using the asterisk. It was for the delta_datafusion::enforce_checks function to format its SQL-query with SELECT * ... in a constraint check. To ensure the enforce_checks function still works, I have expanded the DeltaCheck trait to include as_any() to allow type checking in enforce_checks to condition how the SQL-query must be formatted for different checks.

Related Issue(s)

No related issues

Documentation

No documentation

[ion-elgreco]

@Nordalf can you add a test please :)

[Nordalf]

@ion-elgreco , of course. I will add a test a little later 🚀

Edit: Already seeing the first problem in enforce_checks. Taking a closer look

[Nordalf]

@ion-elgreco check out the updated code. I have modified the DeltaCheck trait with as_any(). Explanation can be seen in my updated description.

I have also included two new tests: one for get_constraints and one for enforce_checks on constraints.

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 10 lines in your changes missing coverage. Please review.

Project coverage is 72.13%. Comparing base (94a2009) to head (c75e0df).

Files with missing lines	Patch %	Lines
crates/core/src/delta_datafusion/mod.rs	89.09%	0 Missing and 6 partials ⚠️
crates/core/src/table/mod.rs	50.00%	3 Missing ⚠️
crates/core/src/operations/constraints.rs	95.83%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3270      +/-   ##
==========================================
+ Coverage   72.11%   72.13%   +0.02%     
==========================================
  Files         143      143              
  Lines       45530    45617      +87     
  Branches    45530    45617      +87     
==========================================
+ Hits        32833    32907      +74     
- Misses      10618    10625       +7     
- Partials     2079     2085       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ion-elgreco]

@Nordalf looks good, can you squash the commits? Then we can merge