-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Variable batch size and LR scheduler #7104
Open
bm-synth
wants to merge
15
commits into
deepspeedai:master
Choose a base branch
from
bm-synth:variable_batch_size_and_lr_2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Variable batch size and LR scheduler #7104
bm-synth
wants to merge
15
commits into
deepspeedai:master
from
bm-synth:variable_batch_size_and_lr_2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Magalhaes <bruno.magalhaes@synthesia.io>
sign off of all commits in tree Signed-off-by: Bruno Magalhaes <bruno.magalhaes@synthesia.io>
…epSpeed into variable_batch_size_and_lr_2
This was referenced Mar 3, 2025
This was referenced Mar 3, 2025
c5615c3
to
810d89b
Compare
tjruwase
reviewed
Mar 4, 2025
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr.py
Outdated
Show resolved
Hide resolved
tjruwase
reviewed
Mar 4, 2025
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr_example.py
Outdated
Show resolved
Hide resolved
tjruwase
reviewed
Mar 4, 2025
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr_example.py
Show resolved
Hide resolved
tjruwase
reviewed
Mar 4, 2025
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr_example.py
Outdated
Show resolved
Hide resolved
tjruwase
reviewed
Mar 4, 2025
deepspeed/runtime/data_pipeline/data_sampling/variable_batch_size_and_lr.py
Show resolved
Hide resolved
…ize_and_lr_example.py Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
…epSpeed into variable_batch_size_and_lr_2
tjruwase
approved these changes
Mar 4, 2025
@bm-synth, please see the formatting failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background and rationale
In many use cases, particularly LLMs, one is faced with inputs (sentences) of variable lengths. A common practice is to pack batches by token count (not a fixed batch size), ie by putting together sentences whose given metric (eg sequence lengths) will add up to an user-provided value. As an example, in Attention is all you need, section 5.1:
Dynamic batch sizes has been requested in DeepSpeed issue 1051, DeepSpeed issue 3455 , Pytorch Lightning issue 16914, huggingface issue 2647 and is available already in many libraries e.g. NVIDIA Triton and Meta FairSeq (implementation here ).
The immediate use case for this is when one needs to maximize GPU utilization. Moreover, this is particularly relevant for curriculum learning where a
BxTxE
(Batch x Time x Embedding) -shaped input should ideally have highB
and lowT
at the early curriculum steps (many short sentences packed together as a batch), and lowB
and highT
at the late steps (few long sentences in the batch). A dynamic sizeT
is already supported by Deepspeed, e.g. in the documentation for pipeline parallelism's reset_activation_shape():However, dynamic
B
is not supported. A dynamicB
would require an adequate increase/decrease of learning rate. This technique has been applied previously, and the two most common LR scaling algorithms have been described as:In practice, the user picks the total token count per batch as the metric that drives batching, instead of batching by sentence count. During runtime, the variable batch size is computed and the LR is adjusted respectively, based on the LR and batch size provided by the config.
Illustration of dynamic batch size, sequence length and LR
Imagine we picked a limit of
30
tokens per batch, and have set a referencelr=1e-3
for atrain_batch_size=2
(in the deepspeed config). The batching algorithm for curriculum may pack the data into batches of short sentences (left) at the early stages, and batches of long sentences (right) as later stages, e.g.:Above, we collected samples until we filled up the batch with at most 30 tokens. The batch sizes (number of samples) became then
10
and4
on the left and right examples, respectively. Using the linear scaling rule, the LR for those batches become5e-3
and2e-3
.Pipeline parallelism
Pipeline parallelism requires the same batch size and same sequence length across all micro-batches in a batch, as the activation sizes must be fixed between gradient accumulation steps. Between batches, these may change, and long as
engine.reset_activation_shape()
is called so that the new shapes are communicated on the first gradient accumulation step in the batch. Enforcing similarBxTxE
between batches may lead to smaller micro-batches. As an example, below we can see an illustration of a 2-node 2-gradient-accumulation-step (ie 4 micro-batches) batching for the same dataset, when preparing data for the regular DDP (left) and for the pipeline parallelism use cases (right):We can see that the pipeline use case (right) has the same
BxTxE
shape across all the 4 micro-batches in the same batch, and in order to respect that, it packs less samples in the batch, when compared to the standard use case (left hand size)Attention Head
For an input of size
BxTxE
the attention has a shape ofTxT
for a mask of fixed size across samples of same size, orBxTxT
for a different mask per sample (when samples have different sizes, as in the dataset above). This 3D attention matrix can be illustrated for the DDP microbatch 1 (picture above top-left, 4 sentences) as:Note the memory savings: the attention head has a size of
BxTxT
, i.e. a linear memory dependency on the batch sizeB
and quadratic memory dependency on the largest sequence lengthT
in the (micro-) batch. Thus, supporting a dynamic sizeT
allows for an increase ofB
.PR overview
This PRs implements dynamic batching and LR scaling. The dataloader and LR scheduler necessary can be retrieved by calling
get_dataloader_and_lr_scheduler_for_variable_batch_size
. A small explanation of that function follows:scale_lr
;batch_by_seqlen
.True
the following parameters:required_microbatches_of_same_sizes
that will force theB
dimension to be the same across all gradient accumulation steps of all dataloaders on a batch;required_microbatches_of_same_lengths
that will force theT
dimension to be the same across all gradient accumulation steps. Works by calling the user-providedsample_padding_fn(sentence, len)
that pads a given sentence to the argument length;batch_by_seqlen
returnsmicrobatch_sample_ids
(the list of sample ids per micro-batch),batch_sizes
(the size of effective batch sizes, andbatch_max_seqlens
(longest sequence across all microbatches in a batch)dataloader_for_variable_batch_size
relies onmicrobatch_sample_ids
and will iterate/collate/pad samples for every batch and return a dataloader that iterates the final (variable-size) batches;lr_scheduler_for_variable_batch_size
relies onbatch_sizes
to compute the learning rate for each effective batch, taking into account the batch size and LR in the config file, and scaling the LR based on the size of each effective batch, and the scaling rule mentioned above (Linear, Square root, etc).lr_scheduler
returned that will either accept either:Optimizer
that will scale the learning rates (in param groups) at every batch, orLRScheduler
, that in this case will first get the learning rate from the scheduler and then scale it accordingly.Example
An example for the use case with and without pipelining is provided in DeepSpeedExamples PR 963 and file
DeepSpeedExamples/training/data_efficiency/variable_batch_size_and_lr/variable_batch_size_and_lr_example.py
. The example shows an attention head with attention of variable-sizedBxTxT
per batch, followed by a fixed size feed forward network. These are the main blocks on a Large Language Model. The feed-forward (or linear layer) that follows the attention head requires a constant input size, equivalent to the largest sentence in the whole dataset, so the output of the attention must be padded (seefeedforward: needs to convert BxTxE to BxMxE by padding extra tokens
in the code).Config
The example file also comments the relevant deepspeed config with comments:
Future work
A follow-up PR will enable dynamic batching when calling
deepspeed.initialize
. I.e. instead of this:we'd ideally have this:
where
initialize
will call internallyget_dataloader_and_lr_scheduler_for_variable_batch_size_deepspeed
.