Fix, bf16 optimizer remove dup loop #7054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
approved these changes
Feb 19, 2025
|
@wukong1992, thanks for the bug fix. Please address the Formatting and DCO check failures |
wukong1992
force-pushed
the
fix-bf16-moe-refresh-params
branch
from
c0f04e2 to
ec29a11
Compare
… loop dup Signed-off-by: shaomin <wukon1992@gmail.com>
wukong1992
force-pushed
the
fix-bf16-moe-refresh-params
branch
from
ec29a11 to
af19de2
Compare
Yejing-Lai
pushed a commit
to Yejing-Lai/DeepSpeed
that referenced
this pull request
Feb 24, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com>
deepcharm
pushed a commit
to deepcharm/DeepSpeed
that referenced
this pull request
Feb 26, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
deepcharm
pushed a commit
to deepcharm/DeepSpeed
that referenced
this pull request
Feb 27, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
gyou2021
pushed a commit
to gyou2021/DeepSpeed
that referenced
this pull request
Feb 28, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: gyou2021 <ganmei.you@intel.com>
tohtana
pushed a commit
that referenced
this pull request
Feb 28, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: Masahiro Tanaka <mtanaka@microsoft.com>
shenzheyu
pushed a commit
to shenzheyu/DeepSpeed
that referenced
this pull request
Mar 5, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: Zheyu SHEN <zyshen@umd.edu>
ys950902
pushed a commit
to ys950902/DeepSpeed
that referenced
this pull request
Mar 6, 2025
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range Signed-off-by: shaomin <wukon1992@gmail.com> Co-authored-by: shaomin <wukon1992@gmail.com> Co-authored-by: Hongwei Chen <33092912+hwchen2017@users.noreply.github.com> Signed-off-by: yisheng <yi.sheng@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bf16 with moe refresh optimizer state from bf16 ckpt will raise IndexError: list index out of range