Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix environment variable export bug for MultiNodeRunner #5878

Merged
merged 8 commits into from
Sep 8, 2024
Merged

fix environment variable export bug for MultiNodeRunner #5878

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1f4123
fix environment variable export bug for MultiNodeRunner
TideDra Aug 8, 2024
f0c68d1
Merge branch 'master' into master
loadams Aug 8, 2024
2fef989
Merge branch 'master' into master
loadams Aug 15, 2024
1afa6f1
Merge branch 'master' into master
loadams Aug 16, 2024
2291f7b
Merge branch 'master' into master
loadams Aug 16, 2024
f8fc9d5
Merge branch 'master' into master
loadams Aug 19, 2024
0bb221f
Merge branch 'master' into master
loadams Aug 26, 2024
bba85f6
Merge branch 'master' into master
loadams Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/launcher/multinode_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def get_cmd(self, environment, active_resources):
"""Return the command to execute on node"""

def add_export(self, key, var):
self.exports[key.strip()] = var.strip()
self.exports[key.strip()] = f"\"{var.strip()}\""

def parse_user_args(self):
return self.args.user_args
Expand Down
Loading