fix: apply ddtrace workaround to chat generator #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
requested review from
julian-risch
and removed request for
anakin87
julian-risch
reviewed
Mar 5, 2025
| @@ -497,7 +497,7 @@ async def _process_response_async( | |||
| :returns: | |||
| A dictionary containing the processed response as a list of ChatMessage objects. | |||
| """ | |||
| if isinstance(response, AsyncStream): | |||
| if streaming_callback is not None: | |||
There was a problem hiding this comment.
Suggested change
| if streaming_callback is not None: | |
| # workaround for https://github.com/DataDog/dd-trace-py/issues/12562 | |
| if streaming_callback is not None: |
julian-risch
reviewed
Mar 5, 2025
| @@ -458,7 +458,7 @@ def _process_response( | |||
| :param streaming_callback: A callback function that is called when a new token is received from the stream. | |||
| :returns: A dictionary containing the processed response as a list of ChatMessage objects. | |||
| """ | |||
| if isinstance(response, Stream): | |||
| if streaming_callback is not None: | |||
There was a problem hiding this comment.
Suggested change
| if streaming_callback is not None: | |
| # workaround for https://github.com/DataDog/dd-trace-py/issues/12562 | |
| if streaming_callback is not None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.