[rust] Add GTE and Gemma2 model #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Aug 18, 2024
| @@ -119,7 +119,7 @@ def save_rust_model(self, model_info, args: Namespace, temp_dir: str, | |||
| if hasattr(config, "model_type"): | |||
| if config.model_type not in [ | |||
| "bert", "camembert", "distilbert", "xlm-roberta", | |||
| "roberta", "nomic_bert", "mistral", "qwen2" | |||
| "roberta", "nomic_bert", "mistral", "qwen2", "new" | |||
There was a problem hiding this comment.
I don't think "new" is a valid model type, there is a better way to detect GTE model?
There was a problem hiding this comment.
https://huggingface.co/Alibaba-NLP/gte-large-en-v1.5/blob/main/config.json
GTE model can be detected either "new" model type or "NewModel" architecture.
| @@ -119,7 +119,8 @@ def save_rust_model(self, model_info, args: Namespace, temp_dir: str, | |||
| if hasattr(config, "model_type"): | |||
| if config.model_type not in [ | |||
| "bert", "camembert", "distilbert", "xlm-roberta", | |||
| "roberta", "nomic_bert", "mistral", "qwen2" | |||
| "roberta", "nomic_bert", "mistral", "qwen2", "new", | |||
There was a problem hiding this comment.
Add a TODO here, we need monitor if Transformer will give a better model type in few, or if there is conflict.
frankfliu
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about