[audio] aarch64 support for audio extension #2250
Conversation
Codecov ReportBase: 72.08% // Head: 71.56% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2250 +/- ##
============================================
- Coverage 72.08% 71.56% -0.53%
- Complexity 5126 6345 +1219
============================================
Files 473 631 +158
Lines 21970 28078 +6108
Branches 2351 2987 +636
============================================
+ Hits 15838 20094 +4256
- Misses 4925 6526 +1601
- Partials 1207 1458 +251
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
extensions/audio/build.gradle
Outdated
| runtimeOnly "org.bytedeco:ffmpeg:5.0-1.5.7:windows-x86_64" | ||
| String arch = System.properties["os.arch"] == "aarch64" ? "arm64" : "x86_64" | ||
| String os = System.properties["os.name"].toLowerCase(Locale.ROOT) | ||
| if (os.contains("mac")) { |
There was a problem hiding this comment.
We should not pick dependencies based on current os.
If we publish the package on mac (our current CI), then only mac user can use this package when download from maven.
There was a problem hiding this comment.
I see, that makes sense. I modified the change here to also include the aarch64 deps rather than pick on current os
siddvenk
force-pushed
the
audio-arm64
branch
2 times, most recently
from
abb80f0 to
160ca6a
Compare
siddvenk
force-pushed
the
audio-arm64
branch
from
160ca6a to
80f5f4f
Compare
Description
updates dependencies and adds aarch64 support for audio extension