[ci] Publish serving tar and zip #2014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankfliu
reviewed
Sep 14, 2022
| if: ${{ github.event.inputs.mode == '' || github.event.inputs.mode == 'snapshot' }} | ||
| run: | | ||
| ./gradlew :serving:distZip -Psnapshot |
There was a problem hiding this comment.
We don't need publish snapshot .zip and .tar file
| if: ${{ github.event.inputs.mode == 'staging' }} | ||
| run: | | ||
| ./gradlew :serving:distZip -Pstaging | ||
| ./gradlew :serving:createDeb -Pstaging |
There was a problem hiding this comment.
Suggested change
| ./gradlew :serving:createDeb -Pstaging | |
| ./gradlew :serving:dZ :serving:createDeb -Pstaging |
xyang16
force-pushed
the
serving_publish
branch
4 times, most recently
from
dc10d33 to
3c75c17
Compare
frankfliu
reviewed
Sep 14, 2022
| DJL_VERSION=$(cat gradle.properties | awk -F '=' '/djl_version/ {print $2}') | ||
| aws s3 cp serving/build/distributions/*.deb s3://djl-ai/publish/djl-serving/ | ||
| aws cloudfront create-invalidation --distribution-id E371VB8JQ6NRVY --paths "/djl-serving/djl-serving_${DJL_VERSION}*" | ||
| aws s3 cp serving/build/distributions/*.tar s3://djl-ai/publish/djl-serving/ | ||
| aws s3 cp serving/build/distributions/*.zip s3://djl-ai/publish/djl-serving/ | ||
| aws cloudfront create-invalidation --distribution-id E371VB8JQ6NRVY --paths "/djl-serving/serving-${DJL_VERSION}*" |
There was a problem hiding this comment.
We only need invalidate once
There was a problem hiding this comment.
The paths are different. One is "djl-serving_", one is "serving-".
frankfliu
reviewed
Sep 14, 2022
| DJL_VERSION=$(cat gradle.properties | awk -F '=' '/djl_version/ {print $2}') | ||
| aws s3 cp serving/build/distributions/*.deb s3://djl-ai/publish/djl-serving/ | ||
| aws cloudfront create-invalidation --distribution-id E371VB8JQ6NRVY --paths "/djl-serving/djl-serving_${DJL_VERSION}*" | ||
| - name: Publish release deb | ||
| aws cloudfront create-invalidation --distribution-id E371VB8JQ6NRVY --paths "/djl-serving/djl-serving_${DJL_VERSION}~SNAPSHOT*" |
There was a problem hiding this comment.
We don't need add ~SNAPSHOT here, none SNAPSHOT version doesn't exist yet
There was a problem hiding this comment.
I can see non SNAPSHOT version like: djl-serving_0.19.0-1_all.deb
There was a problem hiding this comment.
once we published 0.19.0, the snapshot build will be 0.20.0
xyang16
force-pushed
the
serving_publish
branch
from
3c75c17 to
7408533
Compare
xyang16
force-pushed
the
serving_publish
branch
from
7408533 to
b72107d
Compare
frankfliu
approved these changes
Sep 14, 2022
Codecov ReportBase: 72.08% // Head: 69.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2014 +/- ##
============================================
- Coverage 72.08% 69.93% -2.16%
- Complexity 5126 5945 +819
============================================
Files 473 587 +114
Lines 21970 26283 +4313
Branches 2351 2860 +509
============================================
+ Hits 15838 18380 +2542
- Misses 4925 6522 +1597
- Partials 1207 1381 +174
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR is about
Publish serving tar and zip