[pytorch] Add NDList to IValue unit test #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
reviewed
Jun 30, 2022
| public void testMapOfTensor() { | ||
| try (NDManager manager = NDManager.newBaseManager()) { | ||
| NDArray array1 = manager.zeros(new Shape(1)); | ||
| array1.setName("input1.key1"); |
There was a problem hiding this comment.
minor: add some comments to explain why use input1 as prefix? Like group all keys with same prefix into one Map?
zachgk
approved these changes
Jun 30, 2022
Codecov Report
@@ Coverage Diff @@
## master #1762 +/- ##
============================================
- Coverage 72.08% 70.62% -1.46%
- Complexity 5126 5567 +441
============================================
Files 473 527 +54
Lines 21970 24702 +2732
Branches 2351 2680 +329
============================================
+ Hits 15838 17447 +1609
- Misses 4925 5927 +1002
- Partials 1207 1328 +121
Continue to review full report at Codecov.
|
The testing code can be used as example as well Change-Id: I693624fd111afb0a5547d619a03d2cb15831af1b
ylwu-amzn
approved these changes
Jun 30, 2022
ylwu-amzn
reviewed
Jul 2, 2022
| NDArray array5 = manager.ones(new Shape(1)); | ||
| array5.setName("input2.key3"); | ||
| NDList input = new NDList(array1, array2, array3, array4, array5); | ||
| // the NDList is mapped to (input1: Dict(str, Tensor), input2: Dict(str, Tensor)) |
There was a problem hiding this comment.
Any way to generate something like
(input1: Dict(str, list(Tensor)), input2: Dict(str, list(Tensor)))
There was a problem hiding this comment.
- We don't support this currently, it's possible to add nested IValue support.
- But you have to use IValue directly, and use PyTorch specific API, which doesn't work with Translator pattern. something like: https://github.com/deepjavalibrary/djl/blob/master/engines/pytorch/pytorch-engine/src/test/java/ai/djl/pytorch/integration/IValueTest.java#L184-L191
There was a problem hiding this comment.
I created a PR for your issue: #1765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing code can be used as example as well
Change-Id: I693624fd111afb0a5547d619a03d2cb15831af1b
Description
Brief description of what this PR is about