Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix model name detection in loading model from jar #1446

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

frankfliu
Copy link
Contributor

Change-Id: Iafb83bb8176f3f92dec90f78bf07468171b20e97

Description

Brief description of what this PR is about

  • If this change is a backward incompatible change, why must this change be made?
  • Interesting edge cases to note here

Change-Id: Iafb83bb8176f3f92dec90f78bf07468171b20e97
@frankfliu frankfliu requested a review from zachgk as a code owner January 5, 2022 02:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1446 (582ce97) into master (bb5073f) will decrease coverage by 1.38%.
The diff coverage is 48.02%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1446      +/-   ##
============================================
- Coverage     72.08%   70.70%   -1.39%     
- Complexity     5126     5301     +175     
============================================
  Files           473      493      +20     
  Lines         21970    23222    +1252     
  Branches       2351     2533     +182     
============================================
+ Hits          15838    16418     +580     
- Misses         4925     5527     +602     
- Partials       1207     1277      +70     
Impacted Files Coverage Δ
api/src/main/java/ai/djl/modality/cv/Image.java 69.23% <ø> (-4.11%) ⬇️
...i/djl/modality/cv/translator/BigGANTranslator.java 21.42% <ø> (-5.24%) ⬇️
...odality/cv/translator/BigGANTranslatorFactory.java 33.33% <0.00%> (+8.33%) ⬆️
...nslator/InstanceSegmentationTranslatorFactory.java 14.28% <0.00%> (-3.90%) ⬇️
.../modality/cv/translator/YoloTranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...i/djl/modality/cv/translator/YoloV5Translator.java 5.69% <0.00%> (ø)
...odality/cv/translator/YoloV5TranslatorFactory.java 8.33% <0.00%> (-1.67%) ⬇️
...modality/nlp/embedding/TrainableWordEmbedding.java 45.00% <0.00%> (-3.34%) ⬇️
...pi/src/main/java/ai/djl/ndarray/BytesSupplier.java 54.54% <0.00%> (-12.13%) ⬇️
...i/src/main/java/ai/djl/ndarray/NDArrayAdapter.java 15.23% <0.00%> (-0.83%) ⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d66ef...582ce97. Read the comment docs.

@lanking520 lanking520 merged commit efd0dc4 into deepjavalibrary:master Jan 5, 2022
@frankfliu frankfliu deleted the jar branch January 12, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants