-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre-compute pathways for fitting #242
Conversation
Need to have a check case where there are no pathways for the given spin systems and methods |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 111 111
Lines 7132 7173 +41
=========================================
+ Hits 7132 7173 +41
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of arguments for the minimizer is growing. We should split it. Maybe move all args for sim.run() to fcn_kws
. For example,
minner = Minimizer(sf.LMFIT_min_function, params, fcn_args=(sim, processor, sigma), fcn_kws={"opt": opt, "n_jobs": 1))
You may also need to add sim.run() related arguments to the sf.LMFIT_min_function
sim.optimize()
/sim.release()
Addresses #134