boolean widget & some documentation

[daddykotex]

- Summary

While working on the file-system backend, I was working with hugo. hugo uses a draft attribute to let you mark content as draft so it's not included in the output. I found there was no boolean widget, so here it is.

The MR passes npm run lint:staged but I have issues the the pre-commit hooks:

.git/hooks/pre-commit: line 2: ./node_modules/pre-commit/hook: No such file or directory

- Test plan

There's no test for the other widget, so I did not really know where to start here. Let me know if you want one.

- Description for the changelog
Widget for boolean fields

[erquhart]

@daddykotex great addition! Also love the bonus docs improvement, thanks for that.

Two thoughts:

1. Are you up for improving this to use the React Toolbox switch widget? The dependency is already there, and it's a very simple setup.
2. I realize other widgets such as the Number widget are using classes for no reason, but we want to use functional components wherever possible moving forward.

[daddykotex]

Something like:

One thing I'm unsure is the behavior if value is undefined, like if required: false and draft is not in the front matter for example. Right now, I think there's a stack in the console.

[Benaiah]

@daddykotex I think the best way to handle this would be to require a default in the widget declaration in config.yml, and then have missing or undefined values default to that.

[biilmann]

There's still some UX issues with some of the widgets

[Benaiah]

@biilmann did you mean to make that comment on @rafaelconde's PR? I'm not following how it's related to this one.

[daddykotex]

@Benaiah that's a good idea, I'll play around to see how to implement that ;)

[daddykotex]

Ok, I turned it functionnal (AFAIK 😄 ), it uses the switch widget and falls back to the default value or false if not supplied.

But now, I can't save because the validation proccess in ControlHOC.js seems to use refs and react gives undefined as wrappedControl in the function processInnerControlRef.

It blows up on save because validation is triggered and const response = this.wrappedControlValid(); is called and at this point, it's undefined for the boolean controller.

Do you have any idea?

[daddykotex]

Any input here?

[daddykotex]

This implementation works correctly: daddykotex@eb1538c

[Benaiah]

@daddykotex that commit does appear to be working the first time you edit a post, but afterwards I can't open any entry for editing. I'm looking into the issue.

[daddykotex]

OK, so I'll try to be really clear so we avoid wasting time due to confusion.

When I use the class implementation (bool-class branch https://github.com/daddykotex/netlify-cms/tree/bool-class). It works fine. I can save the boolean value, I can have a default value as well.

When I use the fully functional approach (bool branch https://github.com/daddykotex/netlify-cms/tree/bool), it does not work properly. I can't save and this is probably due to what I explained above (related to ref and ControlHOC). I see the following stack on save:

By the way, I rebased both branch on master and I updated the example/config.yml to have a draft using the boolean widget. This way, it might be wasier to test for you.

---

On another note, I see that on FF and Chrome, the included example has a slightly different behavior. On Firefox, the markdown widget has a switch turned on while it's off on chrome:

I think this is completely unrelated though.

[erquhart]

@daddykotex functional components don't have refs, so class is fine.

[daddykotex]

Ok, so the implementation now uses a class.

[Benaiah]

@daddykotex My bad - the bug that I mentioned earlier (#420) was actually unrelated to this PR, and is now fixed. I've tested this again after rebasing onto the latest master and it works fine. 👍 to merge as soon as the config line is removed.

[Benaiah]

We don't want to use the example config as a test case for new features - can this line be removed?

[daddykotex]

will do!

[daddykotex]

removed the line and rebase against master :)

[erquhart]

Simplified just a bit.

[erquhart]

LGTM

[Benaiah]

LGTM