-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
step-85: mathjax typo in Section L^2-Error #14443
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that actually works -- we have some trouble because the text here is also copied into the table of contents at the top. The safer choice would probably be to write it with HTML markup: <i>L<sup>2</sup></i>
. I'd accept that patch if you want to update your pull request!
That said, many thanks for tackling these little things!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to click on "Request changes"...
Thank you, Vladimir. 👍 |
Would you mind addressing the following error?
|
Will certainly do!
…On 11/19/22 11:53, Wolfgang Bangerth wrote:
Would you mind addressing the following error? invalid author
'vyushut' without firstname and lastname hint: for possible solutions,
consult the webpage:
https: //github. com/dealii/dealii/wiki/Commit-authorship — Reply to
this email directly,
ZjQcmQRYFpfptBannerStart
This Message Is From an External Sender
Use caution when opening links or attachments if you do not recognize
the sender.
ZjQcmQRYFpfptBannerEnd
Would you mind addressing the following error?
|invalid author 'vyushut' without firstname and lastname hint: for
possible solutions, consult the webpage:
https://github.com/dealii/dealii/wiki/Commit-authorship
<https://urldefense.com/v3/__https://github.com/dealii/dealii/wiki/Commit-authorship__;!!PTd7Sdtyuw!QDa3jNFVw0wlYAeYZWsMy3UIjrSy6Qr9rQbG3cEaefAYSjSclzqrzQnth06G6bLKgrnMV_2X3IqfD1pR14ikrmNotZo$>
|
—
Reply to this email directly, view it on GitHub
<https://urldefense.com/v3/__https://github.com/dealii/dealii/pull/14443*issuecomment-1320923490__;Iw!!PTd7Sdtyuw!QDa3jNFVw0wlYAeYZWsMy3UIjrSy6Qr9rQbG3cEaefAYSjSclzqrzQnth06G6bLKgrnMV_2X3IqfD1pR14ikR3qvtbU$>,
or unsubscribe
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/A36B6DZQUM3LBKOXI4TDNETWJEAW3ANCNFSM6AAAAAASEP7ZIA__;!!PTd7Sdtyuw!QDa3jNFVw0wlYAeYZWsMy3UIjrSy6Qr9rQbG3cEaefAYSjSclzqrzQnth06G6bLKgrnMV_2X3IqfD1pR14ik58cAeIw$>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@vyushut ping? |
@bangerth respond! |
@vyushut I believe that the system will want you to change things retroactively for the previous commits as well. You might want to "squash" the three commits into one and use the username of the last commit. |
For some reason I couldn't make the squash working. Instead, I edited the authorship of two commits with the old user.name locally and merged it with the remote. |
No, that's not making it any better -- now you have 7 commits for a one-line change :-) Maybe the easiest way to fix this is to close this PR and open another one that contains only one commit with the one-line change and with the user-name correctly set. |
No description provided.