Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method visibility in JsonApiExtra #765

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

yenshirak
Copy link
Contributor

If you load the Jsonapi extra and include Pagy::Backend in a controller then pagy_url_for and pagy_set_query_params will be added as public methods. Only the controller methods that are mapped to routes should be public.

@ddnexus ddnexus merged commit 7cd615f into ddnexus:master Mar 8, 2025
8 checks passed
@ddnexus
Copy link
Owner

ddnexus commented Mar 8, 2025

Thank you!
@yenshirak FYI, the upcoming v10 will not have any scattered around methods like this anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants