-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: locales: zh-CN, zh-HK, zh-TW #751
Conversation
1. 完善 aria_label 2. 优化之前的翻译
Thank you - your contribution is much appreciated. Here is what I have checked / verified: Step 1: Check the pluralization in rails-i18n and note it down.All of the pluralization rules. are Step 2: Check that pagy defines
|
This comment was marked as resolved.
This comment was marked as resolved.
I checked this branch https://github.com/ddnexus/pagy/tree/chinese-locales. Should I close the pull request or what should I do next? |
This comment was marked as resolved.
This comment was marked as resolved.
remove: :other from aria_label key change: item_name which had one_other keys to default to the :other key remove: code comment
@Davidzhu001 I have pushed onto your master branch and attributed you as author via your previously signed commits (and have deleted the previously chinese-locales branch). There is nothing more you need to do. Thank you for your contribution. @ddnexus ready for merging, subject to your review. |
Thanks so much, i was little busy this week. sorry for the late response |
I update the locale file of those three languages