Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pagy_bootstrap_combo_nav_js page selector is rendered as disabled button #381

Closed
2 of 11 tasks
adas172002 opened this issue Mar 29, 2022 · 3 comments
Closed
2 of 11 tasks

Comments

@adas172002
Copy link

Code Issue

  • I researched through the documentation, the pagy issues and a known Search Engine, and there is no reference|report|post|video that solves this problem
  • I did install|upgraded to the latest version of pagy (or the latest 3.* for pagy legacy)
  • I am providing at least one of the following working and self-contained code support that can reproduce this issue:
    • Simple step by step list that would work in IRB with the Pagy::Console
    • Plain ruby file that can run as ruby my-problem.rb
    • Edited copy of the single file pagy_standalone_app.ru
    • Edited copy of the single file pagy_bare_rails.rb
    • Link of my own branch forked from pagy, which contains an added test file
    • Link of my own branch forked from one branch of the Pagy Rails App
    • Link of a standalone docker image downloadable from a docker repository (e.g. dockerhub.com)
    • docker-compose file that can be run with docker-compose up (and doesn't need to be built because it uses only docker images and no local context)

Ruby|Rails|Sinatra|… Versions

ruby 2.7.3, ror 7.0.2.3 with importmap-rails gem, bootstrap 5.1.3 installed via official bootstrap gem w/o jQuery
...

Description

pagy_bootstrap_combo_nav_js is rendering the following HTML code, with page selector input disabled

<div class="pagy-combo-input btn btn-primary disabled" style="white-space: nowrap;">
   <label>Page <input type="number" min="1" max="26" value="6" class="text-primary" style="padding: 0; border: none; text-align: center; width: 3rem;"> of 26</label>
</div>

Steps to reproduce the issue using the provided support

I found no similar issues here.

@benkoshy
Copy link
Collaborator

Right. Apologies, I had forgotten about it.

I'll post a fix shortly.

@benkoshy
Copy link
Collaborator

benkoshy commented Mar 29, 2022

EDIT: Yes you were right. I understand your issue now.

image

Can you please confirm that you are not trying to go to a page before page 1?

benkoshy added a commit to benkoshy/pagy that referenced this issue Mar 30, 2022
@ddnexus
Copy link
Owner

ddnexus commented Mar 30, 2022

@adas172002 Where is the code support required in order to post a code issue?

You have 8 different ways to pick from! Please, pick one, attach it to this issue and I will reopen it.

Thank you.

@ddnexus ddnexus closed this as completed Mar 30, 2022
benkoshy added a commit to benkoshy/pagy that referenced this issue May 12, 2022
Revert "fix ui bug - ddnexus#381: input was disabled"

This reverts commit 3166564.

fix: selector issue in bootstrap 5
benkoshy added a commit to benkoshy/pagy that referenced this issue May 12, 2022
Revert "fix ui bug - ddnexus#381: input was disabled"

This reverts commit 3166564.

fix: selector issue in bootstrap 5
benkoshy added a commit to benkoshy/pagy that referenced this issue May 12, 2022
Revert "fix ui bug - ddnexus#381: input was disabled"

This reverts commit 3166564.

fix: selector issue in bootstrap 5
benkoshy added a commit to benkoshy/pagy that referenced this issue May 12, 2022
Revert "fix ui bug - ddnexus#381: input was disabled"

This reverts commit 3166564.

fix: selector issue in bootstrap 5
benkoshy added a commit to benkoshy/pagy that referenced this issue May 12, 2022
Revert "fix ui bug - ddnexus#381: input was disabled"

This reverts commit 3166564.

fix: selector issue in bootstrap 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants